Skip to content

Commit

Permalink
[PLAT-15219] Fix YBA helm chart with tls enabled install/upgrade flow
Browse files Browse the repository at this point in the history
Summary: [PLAT-15219] Fix YBA helm chart with tls enabled install/upgrade flow

Test Plan:
Before fixing the chart on helm upgrade.
```
[centos@dev-server-anijhawan-4 yugaware]$ helm upgrade chart-1727118860 . -n testtls
Error: UPGRADE FAILED: YAML parse error on yugaware/templates/configs.yaml: error converting YAML to JSON: yaml: line 13: mapping values are not allowed in this context
[centos@dev-server-anijhawan-4 yugaware]$ git stash apply
On branch 2024.1.1
```

After fixing the chart.
```
[centos@dev-server-anijhawan-4 yugaware]$ helm upgrade chart-1727118860 . -n testtls
Release "chart-1727118860" has been upgraded. Happy Helming!
NAME: chart-1727118860
LAST DEPLOYED: Mon Sep 23 19:20:43 2024
NAMESPACE: testtls
STATUS: deployed
REVISION: 5
[centos@dev-server-anijhawan-4 yugaware]$ git status
On branch 2024.1.1
Your branch is up to date with 'origin/2024.1.1'.

```

Reviewers: sanketh, vkumar, dshubin

Reviewed By: dshubin

Subscribers: yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D38334
  • Loading branch information
amannijhawan committed Sep 23, 2024
1 parent 48d16a1 commit 035f935
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions stable/yugaware/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ server.pem: {{ $serverPemContent }}
{{- if and $result (index $result "server.pem") (index $result "ca.pem") -}}
{{- $serverPemContent := ( index $result "server.pem" ) -}}
{{- $caPemContent := ( index $result "ca.pem" ) -}}
ca.pem: {{ $caPemContent }}
server.pem: {{ $serverPemContent }}
ca.pem: {{ $caPemContent }}
server.pem: {{ $serverPemContent }}
{{- else -}}
{{- $caCert := genCA $root.Values.tls.hostname 3650 -}}
{{- $cert := genSignedCert $root.Values.tls.hostname nil nil 3650 $caCert -}}
Expand Down

0 comments on commit 035f935

Please sign in to comment.