Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applied @dirkf's patches for nsig extraction on youtube #32891

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

aiur-adept
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Fixes nsig extraction for youtube

See #32885

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the extra change. I thought there was also a diff against the original patch but apparently not.

youtube_dl/extractor/youtube.py Outdated Show resolved Hide resolved
@dirkf dirkf linked an issue Aug 1, 2024 that may be closed by this pull request
Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed formatting.

test/test_youtube_signature.py Outdated Show resolved Hide resolved
youtube_dl/extractor/youtube.py Outdated Show resolved Hide resolved
@dirkf
Copy link
Contributor

dirkf commented Aug 1, 2024

Thanks for helping out!

The tests all work. You might like to pull the updated version and try running python test/test_youtube_signature.py TestSignature.test_nsig_js_20dfca59 as-is and then after patching if not func_name: to if True or not func_name:, to test the fallback from yt-dlp (again). If that's OK we can merge.

@aiur-adept
Copy link
Contributor Author

LGTM

@dirkf dirkf merged commit 71223bf into ytdl-org:master Aug 1, 2024
14 checks passed
github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Aug 1, 2024
tatparya added a commit to tatparya/youtube-dl that referenced this pull request Aug 2, 2024
[Youtube] Fix nsig extraction for player 20dfca59  (ytdl-org#32891)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Player 20dfca59 has broken YouTube extractor
2 participants