Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cda: fix bug, when cda link was in form cda.pl/video/[id]/vfilm #28937

Closed
wants to merge 1 commit into from
Closed

Conversation

gucio321
Copy link

@gucio321 gucio321 commented May 1, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This pull request fixes #28936 .
because my issue was closed, without any reason, and I wasn't able to find duplication I decided to fix this bug myself.
these chenges should fix bug, when URLs like https://cda.pl/video/[id]/vfilm was not downloaded
btw, I'm not a native python developer, so let me know, if there is another (better) solution of this problem.

@dstftw dstftw closed this in a0df8a0 May 1, 2021
@gucio321 gucio321 deleted the cda branch May 1, 2021 16:04
fossdd pushed a commit to ex-dl/ex-dl that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cda: http error 404 (fix suggestion)
2 participants