[Mixcloud] Harmonize ID generation from lists with full ID generation #27787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remitamine
requested changes
Jan 12, 2021
akx
force-pushed
the
mixcloud-id-correction
branch
from
9d46858
to
7e02822
Compare
remitamine
reviewed
Jan 13, 2021
Mixcloud IDs are generated as `username_slug` when the full ID dict has been downloaded. When downloading a list (e.g. uploads, favorites, ...), the temporary ID is just the `slug`. This made e.g. archive file usage require the download of stream metadata before the download can be rejected as already downloaded. This PR attempts to get the uploader username during the GraphQL query, so the temporary IDs are generated similarly.
akx
force-pushed
the
mixcloud-id-correction
branch
from
7e02822
to
ded0fbd
Compare
dstftw
added a commit
that referenced
this pull request
Jan 16, 2021
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
…ytdl-org#27787) Mixcloud IDs are generated as `username_slug` when the full ID dict has been downloaded. When downloading a list (e.g. uploads, favorites, ...), the temporary ID is just the `slug`. This made e.g. archive file usage require the download of stream metadata before the download can be rejected as already downloaded. This commit attempts to get the uploader username during the GraphQL query, so the temporary IDs are generated similarly.
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Mixcloud IDs are generated as
username_slugwhen the full ID dict has been downloaded. When downloading a list (e.g. uploads, favorites, ...), the temporary ID is just theslug. This made e.g. archive file usage require the download of stream metadata before the download can be rejected as already downloaded.This PR attempts to get the uploader username during the GraphQL query, so the temporary IDs are generated similarly, and archive file checks can occur before the full stream metadata is downloaded.