[eroprofile] Update regexes #23626
[eroprofile] Update regexes #23626
Conversation
Fixes #23200.
|
Keep old regexes as fallbacks. |
(Should be squashed into the previous commit)
|
Done (as separate commit, since I'm using the web UI). I hope the lines aren't too long. |
youtube_dl/extractor/eroprofile.py
Outdated
| thumbnail = self._search_regex( | ||
| r'onclick="showVideoPlayer\(\)"><img src="([^"]+)', | ||
| [r'<div class="playlistItem current">.*<img src="([^"]+)"', r'onclick="showVideoPlayer\(\)"><img src="([^"]+)'], |
There was a problem hiding this comment.
Part in the middle should not be greedy. Also use _parse_html5_media_entries as main path.
There was a problem hiding this comment.
Part in the middle should not be greedy.
Done, thanks.
Also use
_parse_html5_media_entriesas main path.
I'm not sure what you mean… but this change doesn't touch the video_url so far?
(Should be squashed into the previous commits)
(Should be squashed into the previous commits)
|
What’s the status on this? I’m done at the moment, as far as I’m concerned – if you’re waiting for anything else from me, let me know what’s still missing before merging this. |
|
I've already pointed out to use |
|
Yes, and I already said (or tried to say, I guess it wasn’t clear) that a) I wasn’t sure what you meant by that (the “for formats and thumbnail extraction” makes it a bit clearer, thanks), and b) if it means what I think it means, I don’t think it belongs in this pull request, since it’s unrelated beyond affecting the same extractor. I tried to implement this in YetAnotherGhost/youtube-dl#1 (was supposed to be a pull request against this repository but I didn’t pay attention when creating the pull request; can be moved later). Is it more or less what you were thinking of? |
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
It updates the regular expressions following the eroprofile.com site update pointed out in #23200. The title is hopefully stable as long as they stick to
<h1>elements; the thumbnail is a bit more fragile, but at least it's optional. (I could only find it in one place on the page, in the playlist bar above the video, together with other thumbnails.)Note that the first video in
_TESTSappears to no longer exist, but I assume that's unrelated.