Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a librice-io crate for handling IO things from C. #46

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

ystreet
Copy link
Owner

@ystreet ystreet commented Jul 24, 2024

No description provided.

@ystreet ystreet force-pushed the rice-io branch 3 times, most recently from 4c76659 to 4eaaae0 Compare July 25, 2024 08:03
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 74.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (25be304) to head (8ca4204).

Files Patch % Lines
librice-proto/src/conncheck.rs 83.33% 7 Missing ⚠️
librice-io/src/capi.rs 0.00% 4 Missing ⚠️
librice-proto/src/capi.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   84.36%   84.38%   +0.02%     
==========================================
  Files          16       17       +1     
  Lines        2871     2876       +5     
==========================================
+ Hits         2422     2427       +5     
  Misses        449      449              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Only does io things using some low level async primitives.

In the future, may also implement support for more advanced network
handling like GRO/GSO/io_uring.
The equivalant functionality can be done by simply creating a new
ConnCheck.

Also take the check's controlling value directly from the checklist.
Fixes the controlling value in dump_check_state().
@ystreet ystreet merged commit 4c6c667 into main Aug 7, 2024
6 of 7 checks passed
@ystreet ystreet deleted the rice-io branch August 7, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant