Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

[sourcery-ai]

Function pandasModel.data refactored with the following changes:

• Merge nested if conditions (merge-nested-ifs)

[sourcery-ai]

Function EtabsModel.story_drift_results refactored with the following changes:

• Replace range(0, x) with range(x) (remove-zero-from-range)

[sourcery-ai]

Function get_model_dialog.saveResults refactored with the following changes:

• Remove redundant pass statement (remove-redundant-pass)

[sourcery-ai]

Function get_model_dialog.closeEvent refactored with the following changes:

• Hoist repeated code outside conditional statement (hoist-statement-from-if)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.13%.

Quality metrics	Before	After	Change
Complexity	2.22 ⭐	2.13 ⭐	-0.09 👍
Method Length	79.09 🙂	78.83 🙂	-0.26 👍
Working memory	6.30 🙂	6.30 🙂	0.00
Quality	81.50% ⭐	81.63% ⭐	0.13% 👍

Other metrics	Before	After	Change
Lines	456	452	-4

Changed files	Quality Before	Quality After	Quality Change
APItest.py	81.50% ⭐	81.63% ⭐	0.13% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
APItest.py	EtabsModel.story_torsion_check	9 🙂	314 ⛔	16 ⛔	34.99% 😞	Try splitting into smaller methods. Extract out complex expressions
APItest.py	EtabsModel.__init__	19 😞	259 ⛔	10 😞	37.66% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
APItest.py	EtabsModel.story_drift_results	3 ⭐	177 😞	16 ⛔	48.31% 😞	Try splitting into smaller methods. Extract out complex expressions
APItest.py	get_model_dialog.initUI	0	418 ⛔	10 😞	50.84% 🙂	Try splitting into smaller methods. Extract out complex expressions
APItest.py	pandasModel.data	2 ⭐	34 ⭐	10 😞	77.09% ⭐	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.