Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable caret versions instead of tilde versions #55

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

xMAC94x
Copy link
Contributor

@xMAC94x xMAC94x commented Jun 3, 2020

  • this commit basically reverts:
    855bc9b
  • semver is the standart in rust and it could be assumed that crates follow this for their dependencies.
  • especially in larger projects, having tilde dependencies increases the list of dependencies and duplicate versions.
  • even though vek frequently updates those, switching to caret version (at least for most crates) should be sufficient

Hi, i haven't found the reason why vek switched to tilde back in 2017, but maybe returning back to caret version might be a good thing

- this commit basically reverts:
  yoanlcq@855bc9b
- semver is the standart in rust and it could be assumed that crates follow this for their dependencies.
- especially in larger projects, having tilde dependencies increases the list of dependencies and duplicate versions.
- even though vek frequently updates those, switching to caret version (at least for most crates) should be sufficient
@yoanlcq yoanlcq merged commit 93de6f6 into yoanlcq:master Jun 3, 2020
@yoanlcq
Copy link
Owner

yoanlcq commented Jun 3, 2020

Hi,

I agree. This came from a misunderstanding on my part; Back then, I thought tilde requirements were safer, but now, re-reading the doc about dependencies, I must admit that caret requirements are probably better, for the reasons you mentioned.

Let's merge, and I'll publish a new version with these changes. Thanks for the PR!

@xMAC94x
Copy link
Contributor Author

xMAC94x commented Jun 3, 2020

Thank you very much, it will keep the dependency list for our projects much cleaner :)

@yoanlcq
Copy link
Owner

yoanlcq commented Jun 3, 2020

Anytime! The new version, 0.11.1 is now available with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants