Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider re-exporting crates with traits that vek depend on #75

Closed
NiklasJonsson opened this issue May 15, 2021 · 3 comments
Closed

Consider re-exporting crates with traits that vek depend on #75

NiklasJonsson opened this issue May 15, 2021 · 3 comments

Comments

@NiklasJonsson
Copy link

I tried to use Mat4::abs_diff_eq but it seems to be implemented using a trait from another crate (approx). As I understand it, in order to use this I have to add approx to my own Cargo.toml and make sure the versions match. In case of version mismatch (IIRC if I specify a version vek is not compatible with) it won't compile. If I have another dependency which uses approx similarly, I'm not sure I can resolve it if vek and my other dependency don't agree on compatible versions?

Anyhow, I'd prefer if vek re-exported crates (or maybe just the traits) so that I can get the right approx version with something like:
use vek::approx::AbsDiffEq
There is some related discussion in the api-guidelines repo here

@yoanlcq
Copy link
Owner

yoanlcq commented May 15, 2021

This is very useful information! I've published a new version 0.15.1 with what I think is the appropriate fix. Please let me know if that works for you.

@NiklasJonsson
Copy link
Author

It works great, thank you for the quick response!

@yoanlcq
Copy link
Owner

yoanlcq commented May 15, 2021

Anytime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants