Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GenerateAction.php #531

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Update GenerateAction.php #531

merged 3 commits into from
Nov 23, 2023

Conversation

egmsystems
Copy link
Contributor

$this->controller->stdout("Code not generated. Please fix the following errors:\n\n", Console::FG_RED); print fine but the next echo not show inmediatly and better replace echo with $this->controller->stdout

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues

$this->controller->stdout("Code not generated. Please fix the following errors:\n\n", Console::FG_RED);
print fine but the next echo not show inmediatly  and better replace
echo with $this->controller->stdout
@what-the-diff
Copy link

what-the-diff bot commented Jun 9, 2023

PR Summary

  • Change echo to stdout
    Updated method to display output more effectively
  • Add newline at the end of output
    Improved output formatting with added newline

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line for changelog. Thanks.

@samdark samdark added this to the 2.2.7 milestone Jun 9, 2023
@bizley bizley added the type:bug Bug label Nov 22, 2023
@samdark samdark merged commit 38c72a4 into yiisoft:master Nov 23, 2023
11 checks passed
@samdark
Copy link
Member

samdark commented Nov 23, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants