Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect split UTF-8 strings #105

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Fix incorrect split UTF-8 strings #105

merged 2 commits into from
Jul 27, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Jul 27, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Jul 27, 2023

PR Summary

  • Fix for StringHelper::split() method
    This PR includes a bug fix in the StringHelper::split() method which is documented in CHANGELOG.md. This fix makes sure that the function behaves as expected.

  • Updates in the regular expression in StringHelper::split() method
    The regular expression used in the StringHelper::split() method has been improved. This change allows more accurate splitting of the string, which increases the overall performance of string handling within the codebase.

  • Added new test case
    A new test case has been added in StringHelperTest.php. The addition of this test ensures that our StringHelper::split() method behaves correctly under various conditions, thus increasing the reliability of our software.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e9cd0f9) 96.84% compared to head (eb403aa) 96.84%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #105   +/-   ##
=========================================
  Coverage     96.84%   96.84%           
  Complexity      114      114           
=========================================
  Files             4        4           
  Lines           317      317           
=========================================
  Hits            307      307           
  Misses           10       10           
Files Changed Coverage Δ
src/StringHelper.php 93.63% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team July 27, 2023 09:29
@vjik vjik added the status:code review The pull request needs review. label Jul 27, 2023
@vjik vjik merged commit 0953616 into master Jul 27, 2023
17 checks passed
@vjik vjik deleted the fix-test branch July 27, 2023 10:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants