Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add native support for Emacs Org-mode tables #2258

Merged
merged 9 commits into from
Sep 1, 2023
Merged

Conversation

maxecharel
Copy link
Contributor

Hi, while you indicated that Pandoc was supporting Org-mode tables (#1372), I thought it would be nice to have native support in knitr. I therefore gave it a go :) No major changes/adjustment, I didn't want to mess with the well oiled mechanic of table.R ;)

kable(x = head(iris), format = "org", caption = "test")

#+CAPTION: test
| Sepal.Length| Sepal.Width| Petal.Length| Petal.Width|Species |
|-------------+------------+-------------+------------+--------|
|          5.1|         3.5|          1.4|         0.2|setosa  |
|          4.9|         3.0|          1.4|         0.2|setosa  |
|          4.7|         3.2|          1.3|         0.2|setosa  |
|          4.6|         3.1|          1.5|         0.2|setosa  |
|          5.0|         3.6|          1.4|         0.2|setosa  |
|          5.4|         3.9|          1.7|         0.4|setosa  |

Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a bullet in NEWS.md. Thank you!

R/table.R Outdated Show resolved Hide resolved
R/table.R Outdated Show resolved Hide resolved
@yihui yihui linked an issue Aug 28, 2023 that may be closed by this pull request
…table formats are very similar

the two differences are:

1. org uses + as separator for the line under header;
2. org uses #+CAPTION as the caption label
@CLAassistant
Copy link

CLAassistant commented Sep 1, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxecharel Would you please sign the CLA? I have basically rewritten your implementation, but it will still be great if you can sign the contributor agreement so that you don't need to sign it again if you want to make further contributions in future. Thanks!

@yihui yihui merged commit f0d04f2 into yihui:master Sep 1, 2023
9 of 10 checks passed
@maxecharel
Copy link
Contributor Author

Hi @yihui , apologies for the delay in my response; I just see that you've accomplished quite a bit! Unfortunately I had to let my already very limited 'github activity' aside due to time allocation issues, but thank you for all your work :) I have signed the CLA ;)

@yihui
Copy link
Owner

yihui commented Sep 4, 2023

No worries! Thank you anyway! I just happen to be allocating time mainly to Github projects recently :)

@yihui yihui self-assigned this Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for "org-mode" style plain text table
3 participants