-
-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new output format "jira" to kable()
- Issue #2024
#2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng with special cases
yihui
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
3 tasks
kable()
- Issue #2024kable()
- Issue #2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR seeks to fulfill the request made in the issue #2024 . It adds a new output format to
kable()
, more specifically, a"jira"
format. A simple example:To achieve this new functionality, a new argument called
sep.head.col
inkable_mark()
, and a new function calledkable_jira()
were added. This argument defines the separator between each column in the header of the table (i.e. the line with the column names). Withformat = "jira"
, this argument will be set tosep.head.col = "||"
.If the user does not provide a value (or give a
NA
value) for the argumentsep.head.col
, it will be automatically set to thesep.col
value. Because of this behaviour, in other output formats, like"pipe"
or"simple"
, thesep.head.col
argument will be equal tosep.col
:https://github.com/pedropark99/knitr/blob/2024-jira-kable/R/table.R#L393-L394
So
kable_jira()
basically useskable_mark()
withsep.head.col = "||"
to build the output table. By adding this newsep.head.col
argument tokable_mark()
, we might create more flexibility to add new styles and formats in the future forkable()
.Thank you for the attention!