Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of str_trim() with base-R version #2177

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Replace use of str_trim() with base-R version #2177

merged 6 commits into from
Sep 28, 2022

Conversation

rich-iannone
Copy link
Collaborator

@rich-iannone rich-iannone commented Sep 28, 2022 •
edited by yihui

This replaces both uses of stringr::str_trim() with a util function that only uses base R.

#1549

yihui
yihui approved these changes Sep 28, 2022
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks simple enough, so I'll just merge it, and you can move onto the next challenge :)

@yihui yihui marked this pull request as ready for review September 28, 2022 21:22
@yihui yihui merged commit 8fa7d17 into master Sep 28, 2022
@yihui yihui deleted the str-trim-replace branch September 28, 2022 21:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rich-iannone @yihui