Fix of check in color_def() of col being NA #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of R 4.2.0, "Calling if() with a condition of length greater than one gives an error rather than a warning." The utility function color_def() tests if the argument col is NA by if(is.na(col)), which with R 4.2.0 or greater results in an error when e.g. supplying a user specified background color for chunks in an Rnw-file. The proposed change fixes that by converting is.na(col) to length one.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of R 4.2.0, "Calling if() with a condition of length greater than one gives an error rather than a warning." The utility function color_def() tests if the argument col is NA by if(is.na(col)), which with R 4.2.0 or greater results in an error when e.g. supplying a user specified background color for chunks in an Rnw-file. The proposed change fixes that by converting is.na(col) to length one.