-
-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added php engine. #2144
Added php engine. #2144
Conversation
[skip ci]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. php
command line seems indeed simple enough to add this way and not require a eng_exec
wrapping.
@yihui do we need a test in knitr-example
?
I tested on windows, and this works ok too.
No. |
R/engine.R
Outdated
mysql = '-e', node = '-e', octave = '--eval', perl = '-E', psql = '-c', | ||
python = '-c', ruby = '-e', scala = '-e', sh = '-c', zsh = '-c', NULL | ||
python = '-c', ruby = '-e', scala = '-e', sh = '-c', zsh = '-c', php = '-r', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's order them alphabetically.
R/engine.R
Outdated
@@ -874,7 +875,7 @@ local({ | |||
for (i in c( | |||
'awk', 'bash', 'coffee', 'gawk', 'groovy', 'haskell', 'lein', 'mysql', | |||
'node', 'octave', 'perl', 'psql', 'Rscript', 'ruby', 'sas', | |||
'scala', 'sed', 'sh', 'stata', 'zsh' | |||
'scala', 'sed', 'sh', 'stata', 'zsh', 'php' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
Conflicts: DESCRIPTION NEWS.md
php
should be a simple case like perl.I've attached a simple test Rmd document.
test.php.Rmd.md