simplify Rmd parser pattern: all_patterns$md$inline.code #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
([^`]+)\\s* should be equivalent to ([^`]+)
atusy
changed the title
atusy
changed the title
yihui
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Yes, they are equivalent in theory. The only difference is whether the parsed inline R code includes trailing spaces. Trailing spaces don't matter in R code, so this change shouldn't break anything. I'll merge for now and see if it will cause any problems in reverse dependencies before the next CRAN release. Thanks!
[ci skip]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
([^`]+)\\s* should be equivalent to ([^`]+)