Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer evaluation of yaml cell options #2120

Merged
merged 2 commits into from
Apr 8, 2022
Merged

defer evaluation of yaml cell options #2120

merged 2 commits into from
Apr 8, 2022

Conversation

jjallaire
Copy link
Contributor

@jjallaire jjallaire commented Apr 6, 2022

This PR makes my motivating example work correctly:

---
title: "test"
output: html_document
---

```{r}
x <- "Air"
```

```{r}
#| label: fig-test
#| fig-cap: !expr paste(x, "Quality")
plot(mtcars)
```

@yihui It's definitely possible that I haven't thought of everything required here as I don't have a full picture in my mind of the parsing/options/execution pipeline.

Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be good. Thanks!

@yihui yihui merged commit 47af8c2 into yihui:master Apr 8, 2022
cderv pushed a commit to cderv/knitr that referenced this pull request Aug 23, 2022
Co-authored-by: Yihui Xie <xie@yihui.name>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants