Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xcolor instead of color #2085

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Use xcolor instead of color #2085

merged 3 commits into from
Mar 25, 2022

Conversation

yihui
Copy link
Owner

@yihui yihui commented Dec 14, 2021

To avoid the issue latex3/xcolor#10 per suggestion from latex3/latex2e#719. It reverts 4c6978e.

  • This needs a news item and documentation (to explain that xcolor will be used by default).
  • Check reverse dependencies to see if there could be LaTeX package option clashes. If clashes occur, perhaps we can conditionally load xcolor (e.g., if \usepackage[options]{xcolor} is detected in the input document, then don't add it from knitr).
  • The knitr-examples repo needs to be updated accordingly.

This PR shouldn't be merged until after knitr 1.37 is released.

@yihui yihui added the next Issues/PRs considered for the next release label Dec 14, 2021
yihui added a commit to yihui/knitr-examples that referenced this pull request Mar 25, 2022
@yihui yihui marked this pull request as ready for review March 25, 2022 19:00
@yihui yihui merged commit b312280 into master Mar 25, 2022
@yihui yihui deleted the use-xcolor branch March 25, 2022 19:02
cderv pushed a commit to cderv/knitr that referenced this pull request Aug 23, 2022
use xcolor instead of color to avoid the issue latex3/xcolor#10 per suggestion from latex3/latex2e#719
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
next Issues/PRs considered for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant