Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand spin code block pattern #1492

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Expand spin code block pattern #1492

merged 1 commit into from
Jan 12, 2018

Conversation

ruaridhw
Copy link
Contributor

Copies behaviour implemented in #1455 from read_chunks to spin

Allows for code chunks in Haskell and SQL files to be used in spin.

knitr::spin(..., doc = "^(#|--)+'[ ]?")

example.sql

--' Custom documentation lines as specified with
--' the `doc` parameter passed to `knitr::spin`

-- ---- sql_chunk_name, engine='sql'
CREATE OR REPLACE FUNCTION ...

Update spin code block styling
d529e0e 
Copies behaviour implemented in yihui#1455
@yihui yihui added this to the v0.19 milestone Jan 12, 2018
@yihui yihui merged commit 3614242 into yihui:master Jan 12, 2018
yihui
yihui reviewed Jan 12, 2018
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

yihui added a commit that referenced this pull request Jan 12, 2018
@yihui
don't repeat the regex, and roxygenize after #1492
71c93f2
yihui added a commit that referenced this pull request Jan 12, 2018
@yihui
add @ruaridhw to contributors for #1492 and #1484
4d71624
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihui yihui yihui left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
2 participants
@ruaridhw @yihui