Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add eviews to the default list of knit-engines #2158

Closed
3 tasks done
sagirumati opened this issue Aug 15, 2022 · 3 comments · Fixed by #2160
Closed
3 tasks done

Feature request: add eviews to the default list of knit-engines #2158

sagirumati opened this issue Aug 15, 2022 · 3 comments · Fixed by #2160

Comments

@sagirumati
Copy link
Contributor


By filing an issue to this repo, I promise that

  • I have fully read the issue guide at https://yihui.org/issue/.
  • I have provided the necessary information about my issue.
    • If I'm asking a question, I have already asked it on Stack Overflow or RStudio Community, waited for at least 24 hours, and included a link to my question there.
    • If I'm filing a bug report, I have included a minimal, self-contained, and reproducible example, and have also included xfun::session_info('knitr'). I have upgraded all my packages to their latest versions (e.g., R, RStudio, and R packages), and also tried the development version: remotes::install_github('yihui/knitr').
    • If I have posted the same issue elsewhere, I have also mentioned it in this issue.
  • I have learned the Github Markdown syntax, and formatted my issue correctly.

I understand that my issue may be closed if I don't fulfill my promises.

Dear Xie,

Thank you for your effort.

Could you please add eviews to the default list of knit-engines?

I created EviewsR package, which is available on both CRAN and GITHUB

The package adds eviews as a knit-engine for EViews (Econometric Views), which is application for econometric analysis similar to Stata. It also has functions for base R. The package works similar to reticulate.

Thank you.

@yihui
Copy link
Owner

yihui commented Aug 17, 2022

Sure. Please feel free to send a pull request like this:

knitr/R/engine.R

Lines 830 to 836 in 714cc7c

# Target Markdown engine contributed by @wlandau
# Thread: https://github.com/ropensci/targets/issues/503
# Usage: https://books.ropensci.org/targets/markdown.html
# Docs: https://docs.ropensci.org/targets/reference/tar_engine_knitr.html
eng_targets = function(options) {
targets::tar_engine_knitr(options = options)
}

Thank you!

@sagirumati
Copy link
Contributor Author

I sent the PR. Thank you for your effort.

yihui added a commit that referenced this issue Aug 17, 2022
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants