Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Introduce the count() Feature #50

Merged
merged 5 commits into from
Oct 21, 2022
Merged

✨ Introduce the count() Feature #50

merged 5 commits into from
Oct 21, 2022

Conversation

yezz123
Copy link
Owner

@yezz123 yezz123 commented Oct 20, 2022

#48

@yezz123 yezz123 added the enhancement New feature or request label Oct 20, 2022
@yezz123 yezz123 self-assigned this Oct 20, 2022
@yezz123 yezz123 linked an issue Oct 20, 2022 that may be closed by this pull request
@yezz123
Copy link
Owner Author

yezz123 commented Oct 20, 2022

@iron3oxide Here is the count() feature can you review it and give me your overview 🕺🏻

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (431eff3) compared to base (6635cb7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          728       744   +16     
=========================================
+ Hits           728       744   +16     
Impacted Files Coverage Δ
tests/test_errors.py 100.00% <ø> (ø)
ormdantic/generator/_crud.py 100.00% <100.00%> (ø)
ormdantic/generator/_field.py 100.00% <100.00%> (ø)
tests/test_orm.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yezz123 yezz123 merged commit 9166f11 into main Oct 21, 2022
@yezz123 yezz123 deleted the feat/count branch October 21, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: add count query
2 participants