Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multithreading example #2171

Merged
merged 14 commits into from
Nov 23, 2021
Merged

Add multithreading example #2171

merged 14 commits into from
Nov 23, 2021

Conversation

voidpumpkin
Copy link
Member

@voidpumpkin voidpumpkin commented Nov 21, 2021 •
edited
Loading

Description

same as #2087 just with fixed build errors

closes #2087

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@voidpumpkin voidpumpkin added the A-examples Area: The examples label Nov 21, 2021
ranile
ranile previously approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't cloned and tried to run it. Code looks good to me.

examples/web_worker_fib/Cargo.toml Outdated Show resolved Hide resolved
@voidpumpkin
Copy link
Member Author

Planning changes, found some issues

mc1098
mc1098 reviewed Nov 22, 2021
View reviewed changes
Copy link
Contributor

@mc1098 mc1098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo and small change to using value as a number over parsing it from the string value.

examples/web_worker_fib/README.md Outdated Show resolved Hide resolved
examples/web_worker_fib/src/app.rs Outdated Show resolved Hide resolved
@voidpumpkin
Apply suggestions from code review
451bb15 
Co-authored-by: mc1098 <m.cripps1@uni.brighton.ac.uk>
@voidpumpkin
Update examples/web_worker_fib/src/app.rs
083d2a8 
Co-authored-by: mc1098 <m.cripps1@uni.brighton.ac.uk>
mc1098
mc1098 previously approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@mc1098 mc1098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, with my terribly formatted suggestion sorted this LGTM :)

ranile
ranile previously approved these changes Nov 23, 2021
View reviewed changes
@voidpumpkin @WorldSEnder
Update .github/workflows/publish-examples.yml
1a0a5f3 
Co-authored-by: WorldSEnder <WorldSEnder@users.noreply.github.com>
@voidpumpkin voidpumpkin dismissed stale reviews from ranile and mc1098 via 1a0a5f3 November 23, 2021 07:15
@mc1098 mc1098 merged commit c0f584c into yewstack:master Nov 23, 2021
@voidpumpkin voidpumpkin deleted the SpanishPear/master branch November 23, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WorldSEnder WorldSEnder WorldSEnder left review comments

@mc1098 mc1098 mc1098 approved these changes

@ranile ranile ranile approved these changes

Assignees
No one assigned
Labels
A-examples Area: The examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@voidpumpkin @WorldSEnder @mc1098 @ranile @SpanishPear