-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document html_nested! macro and add regression doc-tests for #1527 #1530
Conversation
@Mergifyio update |
Command
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this! I left a few comments for the code snippets but there are also a few language issues that should be fixed.
Perhaps @teymour-aldridge is willing to take a look? Otherwise I'll do it tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that some of this should move from the doc comment into the accompanying documentation.
This is just an initial pass picking up some spelling/grammar errors.
The suggestions are just suggestions, and are more to point out where I think there are mistakes than my pushing for my suggested phrasing/wording to be adopted.
@teymour-aldridge, I agree, at the very least |
I'm thinking that there's too much here for a doc comment and some of this should be moved into the docs. |
Yeah, especially compared to the API docs of the |
Sounds like a plan! |
…anual for html! macro
I've fix language, changed
Actually, I'm prefer to have some very basics concepts in the rustdoc too. At least basic example of using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few issues left.
Co-authored-by: Simon <simon@siku2.io>
Failed documentation tests -- GitHub issue. |
Thanks, @Mingun! |
Description
Documentation for
html_nested!
, typical usage and regression tests for #1527 in documentationChecklist:
./ci/run_stable_checks.sh