Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test #153

Closed
sindresorhus opened this issue Mar 28, 2019 · 4 comments · Fixed by #155
Closed

Fix failing test #153

sindresorhus opened this issue Mar 28, 2019 · 4 comments · Fixed by #155
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Member

sindresorhus commented Mar 28, 2019 •
edited by issuehunt-oss bot
Loading

Issuehunt badges

https://travis-ci.org/yeoman/update-notifier/jobs/512463652

litomore earned $30.00 by resolving this issue!
This was referenced Mar 28, 2019
Closed
Closed
@LitoMore
Copy link
Contributor

LitoMore commented Mar 29, 2019 •
edited
Loading

I found the bug is here:

https://github.com/yeoman/update-notifier/blob/master/index.js#L120

The isNpm().isNpm returned a undefined.

Looks the ava is using the is-npm@1.0.0 for test.

@LitoMore
Copy link
Contributor

LitoMore commented Mar 29, 2019 •
edited
Loading

We could mark as failing test temporary. Then wait for ava update the update-notifier to next version.

LitoMore added a commit to LitoMore/update-notifier that referenced this issue Mar 29, 2019
@LitoMore
Add failing test for yeoman#153
82e0139
sindresorhus pushed a commit that referenced this issue Apr 7, 2019
@LitoMore @sindresorhus
Add failing test for #153 (#154)
14632e4
@IssueHuntBot
Copy link

@IssueHunt has funded $30.00 to this issue.

@LitoMore LitoMore mentioned this issue Apr 11, 2019
Merged
@IssueHuntBot
Copy link

@sindresorhus has rewarded $21.00 to @LitoMore. See it on IssueHunt

  • 💰 Total deposit: $30.00
  • 🎉 Repository reward(20%): $6.00
  • 🔧 Service fee(10%): $3.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix failing test LitoMore/update-notifier
3 participants
@sindresorhus @LitoMore @IssueHuntBot