This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
options.copy work with tests, this time as single commit #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eddiemonge here's my newest attempt. |
|
hmm the tests are failing |
|
oh yeah, i know why. let me fix those first |
stephanebachelier
added a commit
to stephanebachelier/grunt-filerev
that referenced
this pull request
Nov 13, 2014
Make tests more robusts as there is a test in Gruntfile and should help the PR yeoman#38
|
@eddiemonge I think the #65 should fix the test. @mwillerich you may wait for #65 to be merged or rebase on top of master. |
|
Tests work fine these days. Can you rebase this, @mwillerich? |
added 3 commits
June 7, 2015 12:56
|
Why is this PR not in master? I think it's quite handy to keep the originals. |
|
Because it needs a rebase.
|
|
hi @arthurvr, apologies about the delay. I'll try tonight. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is nearly identical to #31. In this PR it comes as a single commit, and I also changed some whitespace formatting in the test.