Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiled file to a dist folder #27

Closed
ylecuyer opened this issue Apr 26, 2015 · 13 comments
Closed

Add compiled file to a dist folder #27

ylecuyer opened this issue Apr 26, 2015 · 13 comments
Labels

Comments

@ylecuyer
Copy link

When using tacit with bower it would be usefull to have tacit.min.css and tacit.css in a dist folder

@albatros2ko
Copy link
Contributor

Actually, there is. The reason why tacit.min.css is in the root directory is for testing purposes while developing the framework locally in your machine, after every compilation of the SCSS files a dist folder will be created containing, for example, tacit-1.0.0.min.css.

tacit.min.css and dist/tacit-1.0.0.min.css are the same but only tacit.min.css is used during development and is ignored/removed before pushing changes to your fork.

@ylecuyer
Copy link
Author

I think you misunderstood the point. What I want to explain is that one
need to compile the scss files to have the resulting css. It is not
possible to start working with tacit by just cloning the repository.
On 27 Apr 2015 00:09, "Vincent Kyle Eusebio" notifications@github.com
wrote:

Actually, there is. The reason why tacit.min.css is in the root directory
is for testing purposes while developing the framework locally in your
machine, after every compilation of the SCSS files a dist folder will be
created containing, for example, tacit-1.0.0.min.css.

tacit.min.css and dist/tacit-1.0.0.min.css are the same but only
tacit.min.css is used during development and is ignored/removed before
pushing changes to your fork.


Reply to this email directly or view it on GitHub
#27 (comment).

@albatros2ko
Copy link
Contributor

Oh, sorry I missed your point. Anyway, now that makes sense.

@yegor256
Copy link
Owner

yegor256 commented Jun 4, 2015

@rultor release, tag is 0.5.4

@rultor
Copy link
Collaborator

rultor commented Jun 4, 2015

@rultor release, tag is 0.5.4

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Jun 4, 2015

@rultor release, tag is 0.5.4

@yegor256 Done! FYI, the full log is here (took me 4min)

@yegor256
Copy link
Owner

yegor256 commented Jun 4, 2015

@jehna
Copy link
Contributor

jehna commented Jun 4, 2015

@yegor256 ah, the branch was __rultor .. Should've chekout to master before commit.

@vote539
Copy link

vote539 commented Sep 30, 2015

I don't have access to bower/node or any of those fancy command line tools on the server that I have to use (shared host). I'd really like just a CSS file I can download and drop in.

@yegor256
Copy link
Owner

yegor256 commented Oct 1, 2015

@vote539 of course, it's here: http://yegor256.github.io/tacit/tacit.min.css

yegor256 pushed a commit that referenced this issue Oct 1, 2015
@filfreire
Copy link
Collaborator

@yegor256, we can close this issue.

With regards to the user request of

It is not possible to start working with tacit by just cloning the repository.

We're already doing this each release, example:
https://github.com/yegor256/tacit/tree/1.2.8/dist

We could follow, for example, Bootstrap's aproach and also place the css results of compilation in a "master"-like branch:
https://github.com/twbs/bootstrap/tree/v4-dev/dist/css

But this violates the idea of the protected master branch discussed in some of your blog posts. And I'd add it would look ugly compared to what we have now, separating development repo and release of artifacts.

@yegor256
Copy link
Owner

@ylecuyer @filfreire that's right, closing

@0crat
Copy link
Collaborator

0crat commented Mar 20, 2018

The job is not in WBS, won't close the order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants