Make commands optional (elastic#9)

* Make commands optional * Adding back prop type for commands, sans isRequired
ycombinator · Nov 27, 2017 · 4948163 · 4948163
1 parent c02c45e
commit 4948163
Showing 1 changed file with 15 additions and 11 deletions.
diff --git a/src/core_plugins/kibana/public/home/components/tutorial/instruction.js b/src/core_plugins/kibana/public/home/components/tutorial/instruction.js
@@ -19,16 +19,13 @@ export function Instruction({ commands, paramValues, textPost, textPre }) {
     post = <Content className="kuiVerticalRhythm" text={textPost}/>;
   }
 
-  const aceOptions = {
-    fontSize: '14px',
-    maxLines: commands.length
-  };
-
-  return (
-    <div className="instruction">
-
-      {pre}
-
+  let commandsMarkup;
+  if (commands) {
+    const aceOptions = {
+      fontSize: '14px',
+      maxLines: commands.length
+    };
+    commandsMarkup = (
       <div className="kuiVerticalRhythm">
         <KuiCodeEditor
           mode="sh"
@@ -39,15 +36,22 @@ export function Instruction({ commands, paramValues, textPost, textPre }) {
           isReadOnly
         />
       </div>
+    );
+  }
 
+  return (
+    <div className="instruction">
+
+      {pre}
+      {commandsMarkup}
       {post}
 
     </div>
   );
 }
 
 Instruction.propTypes = {
-  commands: PropTypes.array.isRequired,
+  commands: PropTypes.array,
   paramValues: PropTypes.object.isRequired,
   textPost: PropTypes.string,
   textPre: PropTypes.string,