Fix tarball file #3221
Merged
Fix tarball file #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, the revert shouldn't be there, I'll strip it |
arcanis
force-pushed
the
fix-tarball-file
branch
from
b5bc96e
to
a54cd2a
Compare
|
👍 |
|
Looks like a few tests failed |
|
Should be fine now |
bestander
reviewed
Apr 26, 2017
| @@ -10,11 +10,16 @@ import {getPackageVersion, runInstall} from '../_helpers.js'; | |||
| import {promisify} from '../../../src/util/promise'; | |||
|
|
|||
| jasmine.DEFAULT_TIMEOUT_INTERVAL = 150000; | |||
|
|
|||
| test.concurrent = test.skip; | |||
|
@arcanis, you forgot to reenable tests |
arcanis
force-pushed
the
fix-tarball-file
branch
from
94fa4eb
to
efb8343
Compare
bestander
pushed a commit
that referenced
this pull request
May 2, 2017
* Fixes #3168 * Adds tests * Fixes linting
|
This PR fixes relative paths but not absolute ones both on Windows and Unix. |
|
I could change the regex to: |
|
It seems to catch everything: https://regex101.com/r/zS5bmW/1 |
|
Looks good to me, can you send a PR when you have a chance? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The offline mirror feature accidentally disabled the codepath that was used for installing packages from
file:protocol. The tests didn't caught this error because they're using a wrapper class,LocalTarballFetcher, that wasn't affected by this issue.