make add command working with latest tag if offline or preferOffline is setted #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for tests! |
|
@bestander you are welcome. I tried to clarify some tests better because runAdd has some magic, if i open a pull request could be interesting for you to discuss? |
|
@voxsim, sure go ahead |
ConAntonakos
pushed a commit
to ConAntonakos/yarn
that referenced
this pull request
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The package constraint resolver had some issue with latest tag and if you try to specify --offline or --prefer-offline it throws exception because it does not retrieve the latest cached version :)
Test plan
I added two test cases and expanded the test for latest tag.
Let me know if it's ok!
cheers,
Simon