Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site navigation being somewhat jumbled at certain viewport widths #6022

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

strogonoff
Copy link
Contributor

What's the problem this PR addresses?

Site navigation issues with bits of text overlapping each other and becoming unreadable, as well as awkward typography.

Screenshot before the fix:

Screenshot 2023-12-14 at 19 50 27

How did you fix it?

  • Allow horizontal scrolling of first top nav group
  • Avoid awkward linebreaks
  • Remove faux placeholder from search button that tries to act as a text input

Screenshot after the fix (note that the scrollbar is hidden unless scrolling is initiated or OS is set up to “always show” scrollbars):

Screenshot 2023-12-14 at 20 07 08

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit c68c716 into yarnpkg:master Jan 3, 2024
21 of 24 checks passed
@arcanis
Copy link
Member

arcanis commented Jan 3, 2024

Seems reasonable, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants