Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 64-byte hashes #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

max619
Copy link

@max619 max619 commented Jun 1, 2021

Currently hashes with 64-byte long output are calculating incorrectly because of incorrect if statement

You can see implementation of blake2b_long method in reference repository.

That PR will fix this problem.

Also, it would be nice to add test for keys longer then 32 bytes (at least for this corner case), however it will lead to rewriting some part of test code, and i'm not really sure if it needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant