Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getGraphStatistics method and GraphStatistics class and it's exported C API #165

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

kpango
Copy link
Member

@kpango kpango commented Jul 11, 2024

The following APIs have been newly added and internally modified in this PR because there are use cases where the contents of the ngt info index command are also used via CAPI.

New APIs

  • CAPI:

    • NGTGraphStatistics struct

      • This is an export structure with members equivalent to C++'s GraphStatistics.
    • ngt_get_graph_statistics

      • CAPI that takes an NGTIndex and returns NGTGraphStatistics.
    • ngt_free_graph_statistics

      • CAPI that purges NGTGraphStatistics allocation.
  • C++:

    • GraphStatistics class

      • An object with a collection of graph statistics, with Getter and Setter, and a toString method for Print.
    • getGraphStatistics

      • Takes an NGT::GraphIndex, constructs GraphStatistics based on the statistics, and returns it.

@kpango kpango changed the title Add getGraphStatistics emethod and GraphStatistics class and it's exported C api Add getGraphStatistics emethod and GraphStatistics class and it's exported C API Jul 11, 2024
@kpango kpango changed the title Add getGraphStatistics emethod and GraphStatistics class and it's exported C API Add getGraphStatistics method and GraphStatistics class and it's exported C API Jul 11, 2024
@kpango kpango force-pushed the feature/capi/add-ngt-graph-statics-api branch 10 times, most recently from 85fb164 to 0796f32 Compare July 12, 2024 08:19
…orted C api

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the feature/capi/add-ngt-graph-statics-api branch from 0796f32 to 6de073d Compare July 12, 2024 08:22
@masajiro
Copy link
Member

Thanks!

@masajiro masajiro merged commit 8395f56 into main Jul 15, 2024
@kpango kpango deleted the feature/capi/add-ngt-graph-statics-api branch July 15, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants