-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement AND of settings #14
base: master
Are you sure you want to change the base?
Conversation
👍 |
could we either: change |
@scsper done I'd wanted to overload |
@juandopazo can you merge and publish the npm ?? |
@lpw could you also update the readme? |
@scsper updated README |
- Define configuration using a YAML file (you can still use the original `Cerebro` object if you want to use JSON) - environment variable overrides - Incorporates [AND of settings](yahoo#14) by @lpw - Updated parts of the codebase to Typescript - Updated parts of the codebase to classes - Updated toolchain to be typescript-based - Added new methods to the config object - Re-written readme / updated usage examples to use the YAML format instead
I've incorporated this PR into an improved version of |
After a few requests for this missing conditional expression, and witnessing the unfortunate workarounds from not having it (usually dropping back to code), this is a overloaded implementation of
setting
which now also takes an array where each item is asetting
and the resulting evaluation is true iff each and every setting also evaluates to true. Similar tobuckets
orenvironment
taking an array.or
This overloads
setting
in a backwards compatible way by checking the type ofsetting
.@scsper @juandopazo @cyrils @markandey
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.