[API v4.0] Publish new methods and message types #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: Telegram API Documentation: https://core.telegram.org/bots/api#editmessagemedia
References: Telegram API Documentation: https://core.telegram.org/bots/api#message
Reference: Telegram API Documentation: https://core.telegram.org/bots/api#sendanimation
Reference: Telegram API Documentation: https://core.telegram.org/bots/api#message
|
So how long till this gets merged? What are we waiting for? |
|
please merge this |
|
@yagop @GochoMugo If possible, merge this asap. |
|
Merged. Wold be good to have tests too. |
|
I'll add the tests asap. |
kamikazechaser
added a commit
to kamikazechaser/node-telegram-bot-api
that referenced
this pull request
Oct 20, 2018
- Update badge to reflect the current update (yagop#625) - Fix broken BitHound badge
Merged
kamikazechaser
added a commit
to kamikazechaser/node-telegram-bot-api
that referenced
this pull request
Oct 26, 2018
Follow up update to yagop#625 - Tests for both methods (sendAnimation, editMediaMessage) have been added. editMediaMessage is nested under sendAnimation, hence both tests are technically under a single block. - Add an improvement/minor fix to the editMediaMessage method, where we now stringify the first parameter (media) object interally within the library. This allows the lib user to simply pass an object as the 1st param without stringifying it.
kamikazechaser
added a commit
to kamikazechaser/node-telegram-bot-api
that referenced
this pull request
Oct 26, 2018
Follow up update to yagop#625 - Tests for both methods (sendAnimation, editMediaMessage) have been added. editMediaMessage is nested under sendAnimation, hence both tests are technically under a single block. - Add an improvement/minor fix to the editMediaMessage method, where we now stringify the first parameter (media) object interally within the library. This allows the lib user to simply pass an object as the 1st param without stringifying it.
kamikazechaser
added a commit
to kamikazechaser/node-telegram-bot-api
that referenced
this pull request
Oct 26, 2018
- Update badge to reflect the current update (yagop#625) - Fix broken BitHound badge
This was referenced Oct 26, 2018
Closed
kamikazechaser
added a commit
that referenced
this pull request
Nov 2, 2018
* Update README badges - Update badge to reflect the current update (#625) - Fix broken BitHound badge * Update badges - Replace coveralls with codecov - Add new appveyor badge * Fix minor typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run docDescription
Update the library with minor changes from the latest bot API update (v4.0 released on 26/07/2018).
Add new methods:
Add new message types:
References