Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsDelivr links #1366

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Update jsDelivr links #1366

merged 1 commit into from
Sep 5, 2017

Conversation

LukasDrgon
Copy link
Contributor

jsDelivr switched to a fully automated system, that can serve files from npm and GitHub. This means all future releases will be available automatically, but will use a new link structure.

I updated the links now so you don't forget to do it when you release a new version.
I also changed the version to the latest one.

You can find links for all files at https://www.jsdelivr.com/package/npm/medium-editor.

Feel free to ping me if you have any questions regarding this change.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 96fae38 on LukasDrgon:patch-1 into ** on yabwe:master**.

Copy link
Contributor

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@j0k3r j0k3r merged commit 5b6931c into yabwe:master Sep 5, 2017
This was referenced Sep 5, 2017
@@ -51,8 +51,8 @@ Run in your console: `npm install medium-editor`
For a custom one:

```html
<script src="//cdn.jsdelivr.net/medium-editor/4.11.1/js/medium-editor.min.js"></script>
<link rel="stylesheet" href="//cdn.jsdelivr.net/medium-editor/4.11.1/css/medium-editor.min.css" type="text/css" media="screen" charset="utf-8">
<script src="//cdn.jsdelivr.net/npm/medium-editor@5.23.2/dist/js/medium-editor.min.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasDrgon why not we change the src to use this src="//cdn.jsdelivr.net/npm/medium-editor@latest/dist/js/medium-editor.min.js" ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishijain if you check the full readme, you have two versions of the links there. One with latest and one with a specific version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad. completely missed it. Thanks for the change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartinKolarik @LukasDrgon maybe you can change the path to the latest version to use the new system

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants