-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTU over socket (second PR) #514
base: master
Are you sure you want to change the base?
Conversation
* Modbus RTU over TCP support (no MBAP header) * fixing test issues * test file * Added missing server functions. --------- Co-authored-by: 1038642892 <1038642892@users.noreply.github.com>
Bump version to fix an issue on ARM platforms
I'll try to find some time to test this soon |
Hello, client.setTimeout(500); It's time out! I think there may be a problem with the following code
|
@@ -903,7 +907,9 @@ class ModbusRTU extends EventEmitter { | |||
// write buffer to serial port | |||
_writeBufferToPort.call(this, buf, this._port._transactionIdWrite); | |||
|
|||
this._port._transactionIdWrite += 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line should be removed
Do you have a full example please? Here's what I've just tried.
|
The previous PR was undone because of a bug, happy to submit patches to work rather than undoing next time.
I've reproduced the issues, tested and issued a patch on this branch, with the help of information provided by @Jalle19.