XRENDERING-667: New lines added when parsing and re-rendering groups in xwiki/2.1 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in xwiki/2.1 * Don't print a new line when closing a group and we're already on a newline. * Add a test.
…in xwiki/2.1 * Remove superfluous this.
tmortagne
approved these changes
Dec 12, 2023
…in xwiki/2.1 * Extend the test for empty lines to cover more cases.
|
This should not be merged as while it fixes the original bug, it introduces another bug which is the removal of a newline at the end of syntax like the following when parsing and rendering it again: We're already losing a newline there at the start of the syntax, but with this "fix" we would also lose one at the end. It is not clear to me whose fault this is as we're already loosing newlines in other cases. It is possible that in this case, this paragraph is to blame, and it should print one more newline, see https://jira.xwiki.org/browse/XRENDERING-684 for similar issues with tables and lists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: https://jira.xwiki.org/browse/XRENDERING-667