Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22314: Navigation tree items have an unexpected shadow with a mobile and dark theme. #3251

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jul 4, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22314

Changes

Description

  • Removed the unexpected style taken from jstree.

Clarifications

  • This style uses a hard coded color, on mobile only. We can only see this inconsistency when testing on low width screens AND dark color themes. We don't have any automated testing with these conditions.

Screenshots & Video

before the PR
Screenshot from 2024-07-04 10-28-27
after the PR
Screenshot from 2024-07-04 11-22-48

Executed Tests

I built mvn clean install -f xwiki-platform-core/xwiki-platform-tree/xwiki-platform-tree-webjar successfully and replaced the jar in my test ditribution to get the screenshot above. Nothing more, since this is a rather specific scope style change.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None

…obile and dark theme.

* Removed the unexpected style taken from jstree.
Copy link

@schnillerman schnillerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE !!!

@surli surli merged commit cf0b731 into xwiki:master Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants