XWIKI-18047: Non existing pages can be rated #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelleduc
added
backport stable-15.10.x
tmortagne
reviewed
Jun 27, 2024
.../xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/internal/SolrRatingsManager.java
Outdated
Show resolved
Hide resolved
manuelleduc
commented
Jun 28, 2024
.../xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/internal/SolrRatingsManager.java
Outdated
Show resolved
Hide resolved
manuelleduc
changed the title
* Provide new DocumentReference#valueOf API to extract
DocumentReferenec from an EntityReference
tmortagne
reviewed
Jul 17, 2024
...odel/xwiki-platform-model-api/src/main/java/org/xwiki/model/reference/DocumentReference.java
Outdated
Show resolved
Hide resolved
* Few improvments in the new API for extracting document reference
from an entity reference
github-actions bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Check server side if the page exists before adding a rating
* Hide the rating UI when the page does not exist
* Provide new DocumentReference#extractReference API to extract
DocumentReferenec from an EntityReference
---------
Co-authored-by: Simon Urli <simon.urli@xwiki.com>
(cherry picked from commit 3b7d494)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Check server side if the page exists before adding a rating
* Hide the rating UI when the page does not exist
* Provide new DocumentReference#extractReference API to extract
DocumentReferenec from an EntityReference
---------
Co-authored-by: Simon Urli <simon.urli@xwiki.com>
(cherry picked from commit 3b7d494)
surli
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Check server side if the page exists before adding a rating
* Hide the rating UI when the page does not exist
* Provide new DocumentReference#extractReference API to extract
DocumentReferenec from an EntityReference
---------
Co-authored-by: Simon Urli <simon.urli@xwiki.com>
(cherry picked from commit 3b7d494)
surli
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Check server side if the page exists before adding a rating
* Hide the rating UI when the page does not exist
* Provide new DocumentReference#extractReference API to extract
DocumentReferenec from an EntityReference
---------
Co-authored-by: Simon Urli <simon.urli@xwiki.com>
(cherry picked from commit 3b7d494)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-18047
Changes
Description
Clarifications
Screenshots & Video
N/A
Executed Tests
Expected merging strategy