[Misc] Clean up a bit xwiki.js to move deprecated stuff #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
commented
Jun 25, 2024
...m-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/xwiki.js
Show resolved
Hide resolved
surli
commented
Jun 25, 2024
| * @deprecated Since XWiki 7.4, the watchlist UI is implemented in a UI extension. This code is still there to not | ||
| * break the retro-compatibility but we can consider removing it. | ||
| */ | ||
| watchlist : { |
There was a problem hiding this comment.
Wondering how much that stuff shouldn't be move to the watch list extension code, instead of being put there.
There was a problem hiding this comment.
Moving it to the watch list extension is not very far from deleting it for good, as the code which stills uses this API is not going to load it.
surli
force-pushed
the
misc-clean-xwikijs
branch
from
6efb5bb
to
68edc62
Compare
surli
force-pushed
the
misc-clean-xwikijs
branch
from
68edc62
to
0425767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
None
Changes
Description
Clarifications
N/A
Screenshots & Video
N/A
Executed Tests
mvn clean install -Pqualityon the module of the changes.Expected merging strategy