XWIKI-21988: Page naming strategy is blocking creation of pages not respecting it #3229

surli · 2024-06-25T13:50:32Z

Jira URL

https://jira.xwiki.org/browse/XWIKI-21988

Changes

Description

The goal here is to immediately display a feedback in the create page dialog telling the user that the reference is wrong before they click on create.

I performed following changes here:

Refactor CreateActionRequestHandler to have a clean separation between retrieving the reference and performing checks over templates
Refactor a bit CreateAction to perform immediate checks over the rights and the name strategy before even checking if the template is chosen: the goal being here to immediately provide exception if there's a problem
Refactor createinline.vm to inject bootstrap modal html elements when used with an ajax request: the idea here is to display an ajax modal instead of the old deprecated xwiki dialog
Refactor xwiki.js to use a jquery ajax call to request and display createinline
Add listener on xwiki:dom:updated events in both create.js and select.js to properly load them in case of dom updates

Clarifications

Screenshots & Video

I took screenshots in the exact same scenario with a link not respecting the name strategy.

Before

With the create modal

With the create page

After

With the create modal

With the create page

Executed Tests

TBD

Expected merging strategy

Prefers squash: Yes
Backport on branches:
- 15.10.x
- 16.4.x

...ation/xwiki-platform-model-validation-api/src/main/resources/ApplicationResources.properties

...n/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources.properties

...ation/xwiki-platform-model-validation-api/src/main/resources/ApplicationResources.properties

…especting it The goal here is to immediately display a feedback in the create page dialog telling the user that the reference is wrong before they click on create. I performed following changes here: * Refactor CreateActionRequestHandler to have a clean separation between retrieving the reference and performing checks over templates * Refactor a bit CreateAction to perform immediate checks over the rights and the name strategy before even checking if the template is chosen: the goal being here to immediately provide exception if there's a problem * Refactor createinline.vm to inject bootstrap modal html elements when used with an ajax request: the idea here is to display an ajax modal instead of the old deprecated xwiki dialog * Refactor xwiki.js to use a jquery ajax call to request and display createinline * Add listener on xwiki:dom:updated events in both create.js and select.js to properly load them in case of dom updates Some work is still needed to display a better information message to the user, in particular about the strategy that should be used.

…especting it * Provide new translations for getting better information from the name strategy * Improve a bit the template for displaying errors

…especting it * Fix page test

…especting it * Fix page object

…especting it * Move translations * Fix typos in translations * Fix since

…especting it (#3229) The goal here is to immediately display a feedback in the create page dialog telling the user that the reference is wrong before they click on create. I performed following changes here: * Refactor CreateActionRequestHandler to have a clean separation between retrieving the reference and performing checks over templates * Refactor a bit CreateAction to perform immediate checks over the rights and the name strategy before even checking if the template is chosen: the goal being here to immediately provide exception if there's a problem * Refactor createinline.vm to inject bootstrap modal html elements when used with an ajax request: the idea here is to display an ajax modal instead of the old deprecated xwiki dialog * Refactor xwiki.js to use a jquery ajax call to request and display createinline * Add listener on xwiki:dom:updated events in both create.js and select.js to properly load them in case of dom updates * Provide new translations for getting better information from the name strategy * Improve a bit the template for displaying errors * Fix page test * Fix page object * Move translations * Fix typos in translations * Fix since (cherry picked from commit 0d91409)

surli added backport stable-15.10.x Used for automatic backport to 15.10.x branch. backport stable-16.4.x labels Jun 25, 2024