Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-22261: Deleted pages table of the page index generates invalid links to permanently delete pages #3205

Merged
merged 1 commit into from
Jul 16, 2024
Merged

XWIKI-22261: Deleted pages table of the page index generates invalid links to permanently delete pages #3205

merged 1 commit into from
Jul 16, 2024

Conversation

manuelleduc
Copy link
Contributor

@manuelleduc manuelleduc commented Jun 13, 2024 •
edited
Loading

Jira URL

https://jira.xwiki.org/browse/XWIKI-22261

Changes

Description

  • When javascript is deactivated, the list of Livetable of the deleted pages of the index is replace with a static table.
  • The delete actions of this table are not well-formed (it contains two unescaped question marks)

Executed Tests

mvn clean install -Pquality,integration-test,docker -f /home/mleduc/xwiki/master/xwiki-platform/xwiki-platform-core/xwiki-platform-index -pl :xwiki-platform-index-ui -amd

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • stable-15.10.x
    • stable-16.4.x

@manuelleduc manuelleduc added the backport stable-15.10.x Used for automatic backport to 15.10.x branch. label Jun 13, 2024
@manuelleduc manuelleduc marked this pull request as ready for review June 13, 2024 14:33
@manuelleduc manuelleduc changed the title XWIKI-22261: Deleted pages table table of the page index generates invalid links to permanently delete pages XWIKI-22261: Deleted pages table of the page index generates invalid links to permanently delete pages Jun 19, 2024
@surli surli merged commit da03cbe into xwiki:master Jul 16, 2024
3 checks passed
This was referenced Jul 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch. backport stable-16.4.x
Projects
None yet
Milestone
No milestone
2 participants
@manuelleduc @surli