Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22204: Underline inline links on the change viewer #3201

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jun 12, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22204

Changes

Description

  • Fixed missing underlining on the inline links in the diff boxes.

Clarifications

  • Since this is a specific UI and structure around the anchor, I decided to go with the solution that's the least generic and just add the helper class to this element.

Screenshots & Video

Before the PR on the ticket report itself.
Here is what it looks like after the PR:
Screenshot from 2024-06-12 15-06-32
We can see that all the inline links in the From version and To version blocks are properly underlined.

Executed Tests

Manual tests only, see above.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None

* Fixed missing underlining on the inline links in the diff boxes.
@surli surli merged commit 82021cc into xwiki:master Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants