change scope to accessModifiers for JavadocVariable in Checkstyle config #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created https://jira.xwiki.org/browse/XCOMMONS-2219 for reference. |
|
Actually it seems I misunderstood and checkstyle/checkstyle#9277 is not included in Checkstyle 8.43 so nothing to do with https://jira.xwiki.org/browse/XCOMMONS-2219. |
|
Correct, checkstyle/checkstyle#9277 is still open. So unfortunately I can't say what checkstyle release it will be part of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkstyle is in the process of changing the
scopeproperty toaccessModifiersinJavadocVariableCheck. This PR will update xwiki's Checkstyle config to accommodate this (breaking) change, which will be included in an upcoming Checkstyle release. When the corresponding Checkstyle version is released, I will turn this draft PR into a (regular) PR and update the Checkstyle version number.The breaking Checkstyle change is subject of checkstyle/checkstyle#9277.