Skip to content

Commit

Permalink
[brcm] Add ENABLE_SYNCD_RPC flag for BRCM syncd-rpc build (sonic-net#179
Browse files Browse the repository at this point in the history
)

If this flag isn't set, then the SYNCD_RPC build variable never gets set (see: https://github.com/Azure/sonic-buildimage/blob/6088bd59ded064f392b7618872e1306057b955e1/rules/syncd.mk#L15).

As a result, syncd never gets added to the list of deps for the syncd-rpc docker here: https://github.com/Azure/sonic-buildimage/blob/master/platform/broadcom/docker-syncd-brcm-rpc.mk

Because of this, the syncd-rpc docker that is currently being built on Jenkins is missing syncd entirely, causing it to crash during startup because it can't find/run any of the syncd binaries.

Signed-off-by: Danny Allen <daall@microsoft.com>
  • Loading branch information
daall authored Oct 29, 2020
1 parent 098ce5c commit c514aad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion jenkins/broadcom/buildimage-brcm-all/Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ mv target/sonic-broadcom.bin target/sonic-broadcom-dbg.bin
make SONIC_CONFIG_BUILD_JOBS=1 $CACHE_OPTIONS target/sonic-broadcom.bin
make SONIC_CONFIG_BUILD_JOBS=1 $CACHE_OPTIONS ENABLE_IMAGE_SIGNATURE=y target/sonic-aboot-broadcom.swi
make SONIC_CONFIG_BUILD_JOBS=1 $CACHE_OPTIONS target/sonic-broadcom.raw
make SONIC_CONFIG_BUILD_JOBS=1 $CACHE_OPTIONS target/docker-syncd-brcm-rpc.gz
ENABLE_SYNCD_RPC=y make SONIC_CONFIG_BUILD_JOBS=1 $CACHE_OPTIONS target/docker-syncd-brcm-rpc.gz
# make SONIC_CONFIG_BUILD_JOBS=1 $CACHE_OPTIONS target/docker-ptf-brcm.gz target/docker-saiserver-brcm.gz
'''
}
Expand Down

0 comments on commit c514aad

Please sign in to comment.