Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send the unit separator for C-_, like some other keyboards #2052

Merged
merged 1 commit into from
May 9, 2019
Merged

Send the unit separator for C-_, like some other keyboards #2052

merged 1 commit into from
May 9, 2019

Conversation

jflatow
Copy link
Contributor

@jflatow jflatow commented May 9, 2019 •
edited by Tyriar
Loading

Fixes #2049

@jflatow jflatow mentioned this pull request May 9, 2019
Open
2 tasks
@Tyriar Tyriar added this to the 3.13.0 milestone May 9, 2019
Tyriar
Tyriar approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, seems to work after the change and it seems to be pretty low risk to add to this release since it should only change the behavior if both ctrl and shift are held (so ctrl+- should still zoom in vscode for example)

@Tyriar Tyriar merged commit c1b5672 into xtermjs:master May 9, 2019
@starpit
Copy link
Contributor

starpit commented May 10, 2019

awesome work. verified.

@Tyriar Tyriar mentioned this pull request May 10, 2019
Merged
10 tasks
@renovate renovate bot mentioned this pull request Jun 6, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

on mac, shift-control-minus is swallowed (emacs undo)
3 participants
@jflatow @starpit @Tyriar