Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that webLinks not interpreted #2038

Merged
merged 1 commit into from
May 4, 2019
Merged

Fix that webLinks not interpreted #2038

merged 1 commit into from
May 4, 2019

Conversation

roottool
Copy link
Contributor

@roottool roottool commented May 3, 2019 •
edited
Loading

Issue number

#1954

Description

This PR changes a pattern of pathClause using #1957 for reference.
And I added the http://bar.io pattern to the test code of webLinks.

Tyriar
Tyriar approved these changes May 4, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 👍

@Tyriar Tyriar added this to the 3.13.0 milestone May 4, 2019
@Tyriar Tyriar merged commit d68c441 into xtermjs:master May 4, 2019
@roottool roottool deleted the fix-that-webLinks-not-interpreted#1954 branch May 4, 2019 07:56
@Tyriar Tyriar mentioned this pull request May 10, 2019
Merged
10 tasks
@renovate renovate bot mentioned this pull request Jun 6, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@roottool @Tyriar