cell representation for joined cells #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Apr 30, 2019
|
@jerch works nicely within Terminus |
|
@Eugeny Could you test this once more before we add it? |
|
Can't try this right now - upgraded to Node 12 (for Electron 5) and xterm's build system uses Gulp 3 which is long unsupported and is now broken |
|
Nevermind - works! Here's a quick and dirty patch to get the build working (sourcemaps are still broken tho) https://gist.github.com/Eugeny/89d3b7b9fd3625161b8c78a416a12560 |
|
@Eugeny Thx for testing ❤️ |
10 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall fix #2028.
@Eugeny I have no way to test it reliably with this repo and the demo. Could you try it out with your terminus build?