-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit event API #2008
Merged
Merged
Explicit event API #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
If |
@vincentwoo onData, etc. return an IDisposable. Hold on to that and call |
oh ho ho ho, fancy |
😎 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the new explicit events API that will replace the old node-like
EventEmitter
. I've converted all internal events over to the newEventEmitter2
, the only usage ofEventEmitter
remaining is withinTerminal
to refire the events so we don't break compatibility until v4.Some of the events have changes a little or been removed, see below:
onLineFeed
onSelectionChange
onData
onKey
onRender
onResize
onScroll
onTitleChange
New events being added:
onCursorMove
, this was already being used by the search addon and also within VS CodeIf anyone sees events they rely upon removed please let me know how you're using it as
on
is now deprecated and will be removed soon.Fixes #1505